Feature/remove sys reqs wildcard #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
suggested changes
May 20, 2019
|
So, I have left the |
jgsogo
suggested changes
May 24, 2019
danimtb
approved these changes
May 24, 2019
Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>
|
@Minimonium please solve the conflicts in the files above and it would be ready for merge. Thanks! |
jgsogo
approved these changes
May 27, 2019
jgsogo
suggested changes
May 27, 2019
jgsogo
approved these changes
May 27, 2019
|
I have just realized that the documentation update is missing in this PR. An example at the bottom of this page: https://docs.conan.io/en/latest/reference/commands/misc/remove.html |
|
Docs: conan-io/docs#1294 |
memsharded
reviewed
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Allow using wildcards to remove system requirements sentinel from cache.
Docs: conan-io/docs#1294
Fixes #4478
It handles the ref case to keep the old behaviour but changes the error message when no pattern or reference has been passed (to highlight that wildcards allowed too now).
I've removed this line:
Since the reference is not needed at this scope anymore, I'm not sure that the query check is still needed since it's the only case of using this function in the program. Consider removing the static function too.