fixed problem with transitive build_requires #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Apr 29, 2019
jgsogo
approved these changes
Apr 30, 2019
lasote
reviewed
Apr 30, 2019
| @@ -148,6 +148,7 @@ def _handle_require(self, name, node, require, dep_graph, check_updates, update, | |||
| new_node.inverse_closure.add(node) | |||
| node.public_deps[new_node.name] = new_node | |||
|
|
|||
| new_node.build_require = node.build_require or require.build_require | |||
There was a problem hiding this comment.
I had to postpone #4738 for 1.16, but please, at least put a comment if the code is new. That is a new corner case that it is impossible for anyone except you to know why. What does it mean that node.build_require is None and why it should take it from require? What is require?
lasote
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fixing exception of transitive build-requires mixed with normal requires
Docs: omit
Close #5043
Address #4987 (comment)
@tags: slow