Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing updated Pyyaml #4945

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Apr 10, 2019

Changelog: omit
Docs: omit

@tags: slow
@PYVERS: py27, py36, py34

Comes from conan-io/docs#1244

@lasote
Copy link
Contributor

lasote commented Apr 10, 2019

Is this a draft to see what happen or do you really think we should unlock it to any higher version?

@memsharded
Copy link
Member Author

Yes, sorry, it should be a draft, I clicked the button too fast, and it cannot be changed to draft later.

@memsharded
Copy link
Member Author

Now, the CI is green, should we constraint the requirement to something like?:

PyYAML>=3.11, <6.0

Assuming that all 5.X versions won't break Conan? I have updated the PR to include that.

There are other requirements not bounded like fasteners or six, but it is unlikely that they will get major versions released.

@memsharded memsharded assigned lasote and unassigned memsharded Apr 10, 2019
@lasote
Copy link
Contributor

lasote commented Apr 10, 2019

Sure, I think we are ok doing that. We could just release a minor if we release any problem, but if apparently is working, go ahead.

@lasote lasote added this to the 1.15 milestone Apr 10, 2019
@memsharded memsharded merged commit 7afeeae into conan-io:develop Apr 15, 2019
@memsharded memsharded deleted the feature/test_new_pyyaml branch April 15, 2019 15:52
@ghost ghost removed the stage: review label Apr 15, 2019
climblinne pushed a commit to climblinne/conan that referenced this pull request Apr 15, 2019
* testing updated Pyyaml

* adding upper bound <6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants