Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default filename for workspaces: conanws.yml (used in install command) #4941

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Default filename for workspaces: conanws.yml (used in install command) #4941

merged 4 commits into from
Apr 10, 2019

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Apr 10, 2019 •
edited
Loading

Changelog: Feature: Default filename for workspaces: conanws.yml (used in install command)
Docs: conan-io/docs#1243

closes #4778

@jgsogo jgsogo added this to the 1.15 milestone Apr 10, 2019
@ghost ghost assigned jgsogo Apr 10, 2019
@ghost ghost added the stage: review label Apr 10, 2019
memsharded
memsharded approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write and link the docs and I will merge, all good.

@jgsogo jgsogo mentioned this pull request Apr 10, 2019
Merged
@jgsogo
Copy link
Contributor Author

jgsogo commented Apr 10, 2019

Done with docs, improved help message of path argument.

memsharded
memsharded approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when CI finish

@jgsogo jgsogo merged commit 7679db8 into conan-io:develop Apr 10, 2019
@ghost ghost removed the stage: review label Apr 10, 2019
@jgsogo jgsogo deleted the feature/4778-ws-default_filename branch April 10, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

[workspaces] Use conanws.yml by default if no workspace file given
2 participants
@jgsogo @memsharded