Always remove package folder in conan create

[danimtb]

Changelog: Bugfix: Remove package folder in conan create even when using --keep-build
Docs: omit

• Refer to the issue that supports this Pull Request: closes package dir not cleaned when using conan create with -kb  #4804
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[jgsogo]

If the idea is to delete the package_folder every time we are going to build, I would move the remove_folder_raising(package_folder) line to the place where the BUILD & PACKAGE comment is (here).

It would be out of the if skip_build and executed before the build() method, I'm thinking about a class with the cmake.build(), cmake.install() inside the build() method, we need to delete the package_folder before building (not after).

[danimtb]

Yes, you are totally right! Did not think about that. Thanks

[danimtb]

Requested changes done. I haven't added a test as the case fo cmake.install() in the build() method should be well covered in this test https://github.com/conan-io/conan/blob/develop/conans/test/functional/build_helpers/cmake_install_package_test.py#L46

[jgsogo]

But that test has a client.run("remove * --force")... maybe another one could cover this use case (I don't know how to look for it).

[danimtb]

That test should be enough to prove that the package folder is available in build() time. I have been thinking about the case of cmake.install() in build() together with conan create --keep-build and it wouldn't work either, as the build() is totally skipped when using --keep-build. That is one of the reasons we recomend using it in the package(): https://docs.conan.io/en/latest/howtos/cmake_install.html (we should update and include the reasons there).

[jgsogo]

We are almost there, but I have a couple of doubts 💭

[jgsogo]

👍

[memsharded]

If using dedent, better really indent the contents one more indent, so it is not aligned with test_conanfile.