Show profile name when detect a new one (#4818) #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect warning message will show the correct profile name instead of print only "default". Signed-off-by: Uilian Ries <uilianries@gmail.com>
ghost
assigned 
danimtb
reviewed
Mar 25, 2019
memsharded
approved these changes
Mar 25, 2019
|
Please check the broken tests. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
requested changes
Mar 26, 2019
- When the profile name is a file path, it should exclude the dir path and show only the profile name Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
requested changes
Mar 26, 2019
- Print profile name and profile path based on its path; Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
|
memsharded
requested changes
Mar 26, 2019
- When looking for default settings, use the profile file path, instead of creating a path by its name Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Cache should consume the default profile path. Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
The testing service is out. Let's wait ;) |
|
Service back but still failing |
|
This time is my fault. I didn't check on Windows. |
- It doesn't matter which platform is running, detect_default_settings does not parse the path. Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
All green again! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning message will show the correct profile name instead of printing only "default".
Changelog: Fix: Show the correct profile name when detect a new one (#4818)
Docs: Omit
fixes #4818
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.