Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify revision_mode for each recipe #4767

Merged
merged 11 commits into from
Mar 25, 2019
Merged

Allow to specify revision_mode for each recipe #4767

merged 11 commits into from
Mar 25, 2019

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Mar 19, 2019 •
edited
Loading

Changelog: Feature: Allow to specify revision_mode for each recipe, values accepted are scm or hash (default)
Docs: conan-io/docs#1126

@ghost ghost assigned jgsogo Mar 19, 2019
@ghost ghost added the stage: review label Mar 19, 2019
@jgsogo jgsogo added this to the 1.14 milestone Mar 19, 2019
@jgsogo jgsogo changed the title Issue/4413 revision mode Allow to specify revision_mode for each recipe Mar 19, 2019
@jgsogo jgsogo marked this pull request as ready for review March 19, 2019 14:44
@jgsogo jgsogo requested a review from lasote March 19, 2019 14:45
@jgsogo jgsogo mentioned this pull request Mar 19, 2019
Merged
danimtb
danimtb previously approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a missing test case IMO

conans/test/functional/command/export_test.py Show resolved Hide resolved
@jgsogo jgsogo dismissed danimtb’s stale review March 20, 2019 10:33

"auto" has been deprecated as revision_mode

danimtb
danimtb approved these changes Mar 21, 2019
View reviewed changes
conans/test/functional/command/export_test.py Outdated Show resolved Hide resolved
@memsharded memsharded assigned lasote and unassigned jgsogo and danimtb Mar 24, 2019
@lasote lasote merged commit b9a7696 into conan-io:develop Mar 25, 2019
@ghost ghost removed the stage: review label Mar 25, 2019
@jgsogo jgsogo deleted the issue/4413-revision_mode branch March 25, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@danimtb danimtb danimtb approved these changes

@lasote lasote Awaiting requested review from lasote

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

Should the default revision mode be "hash"? Revisions: Choose revision_mode
4 participants
@jgsogo @danimtb @memsharded @lasote