Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error instead of skipping files if short_paths #4766

Merged
merged 3 commits into from
Mar 19, 2019
Merged

raise error instead of skipping files if short_paths #4766

merged 3 commits into from
Mar 19, 2019

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Raise an error if source files cannot be correctly copied to build folder because of long paths in Windows.
Docs: omit

Close #4484

@ghost ghost assigned memsharded Mar 19, 2019
@ghost ghost added the stage: review label Mar 19, 2019
@memsharded memsharded added this to the 1.14 milestone Mar 19, 2019
@memsharded memsharded assigned jgsogo and unassigned memsharded Mar 19, 2019
jgsogo
jgsogo reviewed Mar 19, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the comments, but overall I approve 👍 , for sure we don't want to ignore those files.

conans/client/installer.py Outdated Show resolved Hide resolved
@ghost ghost assigned memsharded Mar 19, 2019
@memsharded memsharded merged commit fe6d820 into conan-io:develop Mar 19, 2019
@ghost ghost removed the stage: review label Mar 19, 2019
@memsharded memsharded deleted the feature/raise_short_paths branch March 19, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo left review comments

Assignees

@jgsogo jgsogo

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.14
2 participants
@memsharded @jgsogo