-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix meson build_type #4489
fix meson build_type #4489
Conversation
I'm not sure if this is an error, I've just installed Meson and this is what I get:
It looks like |
If try to build some project, it will see the follow warning: Also, the package xkbcommon is a good example, you can see log here |
You are right, @uilianries. Thanks a lot! Please, @ericLemanissier, modify the test that is failing to fix it. Thanks! |
default_library has 8 occurences whereas default-library has only 1, and it is documentation. it looks like a typo to me. |
Meson's documentation currently mentions default-library option, but it is a typo, the proper option is default_library
BTW, should we include |
Using arguments it is by default ( |
hmm, you are right, as done for cmake. Only libdir is enough for xkbcommon, but because we only need to install the libraries. |
What would the default be for libexecdir ? meson has 'libexec' as default value |
Here I need to invoke @danimtb, he worked on that for Autotools if I remember it well. |
The same used for CMake: https://github.com/conan-io/conan/blob/develop/conans/client/build/cmake_flags.py#L282 |
the typo on default-/_library documentation is fixed upstream: mesonbuild/meson#4897 |
As @uilianries referenced above, I followed in autotools the same pattern of cmake. |
Upsss 😓 , this PR should have been merged into |
* fix meson build_type Meson's documentation currently mentions default-library option, but it is a typo, the proper option is default_library * set default meson dir options
Meson's documentation currently mentions default-library option,
but it is a typo, the proper option is default_library
Changelog: Bugfix: meson build type actually reflects recipe shared option
Docs: omit
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.