Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise more meaningful messages from GraphInfo parsing #4447

Closed
wants to merge 3 commits into from

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Feb 1, 2019

Changelog: omit
Docs: omit

Related to #4443, add more meaningful errors related to graph_info.json parsing. The output for the linked issue would have been:

⇒  conan info .
ERROR: Error parsing GraphInfo from file '/Users/jgsogo/dev/conan/issues/tmp2/graph_info.json': Error related to GraphInfo text content: Required node 'root' is not present

@lasote I'm not sure if I should open this PR against develop or against a minor 1.12.1.

closes #4443

@jgsogo jgsogo requested a review from memsharded February 1, 2019 11:55
@ghost ghost assigned jgsogo Feb 1, 2019
@ghost ghost added the stage: review label Feb 1, 2019
@lasote
Copy link
Contributor

lasote commented Feb 4, 2019

Develop. We try to keep the minor versions as lean as possible to fix the bugs there. AFAIK this is not a bug but an improvement.

@memsharded
Copy link
Member

Superseded by #4458, to be released in patch 1.12.1

@memsharded memsharded closed this Feb 4, 2019
@ghost ghost removed the stage: review label Feb 4, 2019
@jgsogo jgsogo deleted the fix/graph_info-load branch February 6, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using 'conan info .' (Conan 1.12.0)
3 participants