-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4331 Bump pyOpenSSL version for OSX #4333
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries I am not fully sure how do |
I agree with @SSE4, probably the best we can do is to open the PR in CPT to align the cryptography and pyopenssl versions. WDYT? @uilianries?
|
I can't recall, but I think there was something: Is there some reason why conan shouldn't be using the latest pyOpenSSL? (18.0.0 https://pypi.org/project/pyOpenSSL/#history) |
That is not the point. It would solve the reported issue only circumstantially. The root cause is that the requirements from cpt and conan are not aligned. Bump pyopenssl would make it match today, but only tomorrow. |
I agree with both. We need to align both versions to avoid new problem in the future. But also I think is a good idea keep pyOpenSSL updated for security. Why not change CPT to |
Ok, let's do that. |
I'm gonna patch soon |
Related PR: conan-io/conan-package-tools#319 |
closes #4331
Changelog: Fix: Bumped requirement of pyOpenSSL on OSX to
>=16.0.0, <19.0.0
Docs: Omit
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.