Added sha1 header always #4303
Merged
Added sha1 header always #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
memsharded
approved these changes
Jan 15, 2019
uilianries
reviewed
Jan 15, 2019
| @@ -19,16 +19,18 @@ def __init__(self, requester, output, verify, chunk_size=1000): | |||
| self.verify = verify | |||
|
|
|||
| def upload(self, url, abs_path, auth=None, dedup=False, retry=1, retry_wait=0, headers=None): | |||
| # Send always the header with the Sha1 | |||
| headers = headers or {} | |||
| headers["X-Checksum-Sha1"] = sha1sum(abs_path) | |||
There was a problem hiding this comment.
dedup is configured by the server capabilities, that means SHA-1 will be included even when a server is not prepared to used it. Do you know if it could affect conan_server or Bintray?
There was a problem hiding this comment.
according to the HTTP specification, unknown headers should be just safely ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Conan client now always include the
X-Checksum-Sha1header in the file uploads, not only when checking if the file is already there with a remote supporting checksum deploy (Artifactory)Docs: omit
Closes #3544