Add <package>_VERSION output variable to cmake_find_package generator #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standard find_package() output variable allows users to query the found library version. Note this variable is defined for requested packages only, not _VERSION variables are defined for the package dependencies.
danimtb
reviewed
Jan 9, 2019
| SET({name}_INCLUDE_DIRS {deps.include_paths}) | ||
| SET({name}_INCLUDES {deps.include_paths}) | ||
| SET({name}_DEFINITIONS {deps.defines}) | ||
| SET({name}_LIBRARIES "") # Will be filled later | ||
| SET({name}_LIBRARIES_TARGETS "") # Will be filled later, if CMake 3 | ||
| SET({name}_LIBS "") # Same as {name}_LIBRARIES | ||
|
|
||
| mark_as_advanced({name}_FOUND {name}_INCLUDE_DIRS {name}_INCLUDES | ||
| {name}_DEFINITIONS {name}_LIBRARIES {name}_LIBS) | ||
| find_package_handle_standard_args({name} |
There was a problem hiding this comment.
Could this (https://cmake.org/cmake/help/v3.0/module/FindPackageHandleStandardArgs.html) additionally help with the casing of the package names when using this generator or nothing to do?
There was a problem hiding this comment.
The thing is that more recent versions of cmake mark that FOUND_VARIABLE parameter as obsolete. See for example https://cmake.org/cmake/help/v3.13/module/FindPackageHandleStandardArgs.html which states "This exists only for compatibility with older versions of CMake and is now ignored. Result variables of both names are always set for compatibility."
lasote
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Added
xxxx_VERSIONoutput variable forcmake_find_packagegenerator. Improved also usingfind_package_handle_standard_argshelper.Docs: conan-io/docs#1005
This standard find_package() output variable allows users to query
the found library version. Note this variable is defined for requested
packages only, no _VERSION variables are defined for the package
dependencies: