Feature/use env in package command #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Dec 28, 2018
There was a problem hiding this comment.
This looks great, thank you!
The only thing, I think the test is mostly about the "conan package" test, than a "conan_api" test. Not testing the api itself, but testing the local "package" behavior. But don't worry, I'll merge it, and if anything move it later. Good job!
NoWiseMan
pushed a commit
to NoWiseMan/conan
that referenced
this pull request
Jan 9, 2019
* test for package command using recipe's environment * package command uses recipe's environment fixes conan-io#4198 * fixed test for Windows paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4198
Changelog: Bugfix: Apply the environment to the local conan package command
Docs: Omit