[DO NOT MERGE] Add tests related to SCM feature (scm_folder and SVN monorepo) #4193
Conversation
ghost
assigned
conans/client/cmd/export.py
Outdated
| # Generate the scm_folder.txt file pointing to the src_path | ||
| src_path = scm.get_repo_root() | ||
| save(scm_src_file, src_path.replace("\\", "/")) | ||
| if get_bool_from_text(os.environ.get("USE_SCM_FOLER", "True")): |
There was a problem hiding this comment.
These changes are here just to be able to run tests without the scm_folder.txt file.
There was a problem hiding this comment.
USE_SCM_FOLER => USE_SCM_FOLDER?
There was a problem hiding this comment.
🤦♂️ ...at least it was copy/pasted everywhere
There was a problem hiding this comment.
If this is only for testing I don't like it, but we could consider this a feature naming in properly: CONAN_USE_SCM_FOLDER. To discuss.
There was a problem hiding this comment.
Right now it is only to make these tests possible. I want you all to review the tests, check the failing ones, they are showing some bugs that cannot be fixed without adding something else to the model.
|
Agree this is important, and need some thinking and fixes. |
jgsogo
changed the title
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
@conan-io/barbarians, here are two tests that are failing related to SCM feature (the optimization of the
scm_folder.txtfile). I want you to take a look at them:conan create ..one, from the same folder and from a different one,... some use-cases related to the monorepo checkout fails, others print ais not a working copySVN warning.Have a look to: #3831 (SVN warning, last comment), #3786
If fixed, it should close #4218 and close #4222