-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove files containing Macos meta-data #4103
Conversation
Please, as we discussed I would like to know when and why it was failing, because depending on it we could choose how to fix it. So, finally failing with the |
In the test you can see how the offending file appears in the system. If a copy is performed it vanish. That is the difference between the two workflows: one is making a copy while the other one isn't. Adnn explains everything about it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that this feature was due to downloading zip or tgz from the internet.
That is, the tools.get()
, tools.unzip()
, etc. I cannot see interface for this functionality.
On the other hand it is also affecting the core conan zip-unzip of .tgz, which we commented not to modify, as it has not been a problem so far.
So I suggest to move the
if clean_macos_dot_files:
dot_clean(dest_folder)
functionality to the corresponding tools
section.
Please, feedback from @lasote too.
This has nothing to do with the previous behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the docs
I won't, there is a checkbox left in the first comment 👍 |
* if it is going to be a local import, reduce scope * clean dot files in Macos * pass parameter to uncompress function * do nothing with the outputs * test to check where the metadata is being lost * add unittests for dot clean util * ups * work on tmp folder * uneeded changes * rename tool to mac_dot_clean, do not remove temp files * renamed to 'apple_dot_clean'
Changelog: Feature: Remove files containing Macos meta-data (files beginning by
._
)conan create
? #3529