import conanfile just once #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danimtb
reviewed
Dec 10, 2018
jgsogo
reviewed
Dec 10, 2018
| client = TestClient() | ||
| conanfile = """from conans import ConanFile | ||
| mycounter = 0 | ||
| class Pkg(ConanFile): |
There was a problem hiding this comment.
Please, add a counter associated with the instance.
lasote
reviewed
Jan 2, 2019
| @@ -181,6 +181,7 @@ class SayConan(ConanFile): | |||
|
|
|||
| def root(self, content, update=False): | |||
| processed_profile = ProcessedProfile() | |||
| self.loader.cached_conanfiles = {} | |||
There was a problem hiding this comment.
Same comment as @jgsogo. It shouldn't be necessary. Why did you add it? Maybe we are missing something.
There was a problem hiding this comment.
Please check the above comment.
lasote
approved these changes
Jan 2, 2019
|
Missing docs! Shouldn't be merged until we have it. |
|
As you wanted to discuss it I tagged it as whiteboard so you can explain it. |
NoWiseMan
pushed a commit
to NoWiseMan/conan
that referenced
this pull request
Jan 9, 2019
* import conanfile just once * reset cache * fixing tests * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Optimize the graph loading, specially of build-requires, by avoiding importing more than once the same conanfile.py
Docs: Omit
This optimization could be relevant to flatten the dependency graph when build requires are applied to the whole graph.