Feature/fix python requires imports #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag tests related to SVN (and a couple using Git)
ghost
assigned 
jgsogo
suggested changes
Oct 29, 2018
conans/client/loader.py
Outdated
| @@ -228,7 +228,7 @@ def _parse_file(conan_file_path): | |||
| try: | |||
| module_id = str(uuid.uuid1()) | |||
| current_dir = os.path.dirname(conan_file_path) | |||
| sys.path.append(current_dir) | |||
| sys.path.insert(0, current_dir) | |||
There was a problem hiding this comment.
It won't ever happen, but... I would put these three lines outside the try block to be sure that the finally block removes the inserted path (otherwise, if one of these lines raises, we are removing something else from the path list).
danimtb
approved these changes
Oct 30, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
…equires_imports Feature/fix python requires imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: BugFix: Fix conflicting multiple local imports for python_requires
Fix #3874