Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed builds dirty checks #3834

Merged
merged 1 commit into from
Oct 26, 2018
Merged

failed builds dirty checks #3834

merged 1 commit into from
Oct 26, 2018

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 23, 2018 •
edited
Loading

Changelog: Fix: Implement dirty checks in the cache build folder, so failed builds are not packaged when there is a build_id() method.

@ghost ghost assigned memsharded Oct 23, 2018
@ghost ghost added the stage: review label Oct 23, 2018
@memsharded memsharded added this to the 1.9 milestone Oct 23, 2018
@memsharded memsharded assigned lasote and unassigned memsharded Oct 23, 2018
@memsharded memsharded requested a review from jgsogo October 23, 2018 22:18
@lasote lasote merged commit 42248cb into conan-io:develop Oct 26, 2018
@ghost ghost removed the stage: review label Oct 26, 2018
@memsharded memsharded deleted the feature/failed_build_dirty branch October 26, 2018 10:25
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@memsharded @lasote
failed builds dirty checks (conan-io#3834)
db702d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @jgsogo @lasote