Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of tqdm requirement #3823

Merged
merged 4 commits into from
Oct 26, 2018
Merged

Bump version of tqdm requirement #3823

merged 4 commits into from
Oct 26, 2018

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Oct 22, 2018

Changelog: Fix: Bump version of tqdm requirement to >=4.28.0

  • Refer to the issue that supports this Pull Request: Related to "/usr/local/man" pip permissions needed #3785
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@danimtb danimtb added this to the 1.9 milestone Oct 22, 2018
@ghost ghost assigned danimtb Oct 22, 2018
@ghost ghost added the stage: review label Oct 22, 2018
memsharded
memsharded reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the idea was to use upstream tqdm>=4.28.0, not the conan fork now that it shouldn't be necessary.

@danimtb
Copy link
Member Author

danimtb commented Oct 23, 2018

oh, yes! Sorry

jgsogo
jgsogo suggested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to tqdm/tqdm#629 (comment) it should be 4.28.1

conans/requirements.txt Outdated Show resolved Hide resolved
@jgsogo @danimtb
Use 4.28.1
b61100a 
Co-Authored-By: danimtb <danimanzaneque@gmail.com>
lasote
lasote suggested changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not , <5?

@ghost ghost assigned danimtb Oct 25, 2018
@lasote lasote merged commit aa78952 into conan-io:develop Oct 26, 2018
@ghost ghost removed the stage: review label Oct 26, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@danimtb @lasote
Bump version of tqdm requirement (conan-io#3823)
99e1348 
* bump version of tqdm requirement

* fix

* Use 4.28.1

Co-Authored-By: danimtb <danimanzaneque@gmail.com>

* Update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@lasote lasote lasote approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees

@lasote lasote

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@danimtb @jgsogo @lasote @memsharded