#3671 Add attribute tags #3702
Merged
#3671 Add attribute tags #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
danimtb
approved these changes
Oct 10, 2018
jgsogo
approved these changes
Oct 10, 2018
memsharded
reviewed
Oct 10, 2018
- Support new attribute on Conafile: tags Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Validate both inspect and info commands using tags as attribute Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Fix attribute order to validate inspect command Signed-off-by: Uilian Ries <uilianries@gmail.com>
- We believe that topics is a better name, because tags remember svn and git features. - We voted also for labels but topics sounds better. - Thanks to @SSE4 for 'topics' Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Homepage is optional but will be listed by info and inspect commands - Update unit tests to validate homepage - Update topics to be used as tuple Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
force-pushed
the
feature/attribute-tags
branch
from
5a64a34 to
7a90b4f
Compare
|
what does mean that error? https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-3702/4/pipeline |
|
Relaunched CI |
|
This is adding |
|
There is a PR related to topics on conan-io/docs but I don't know how to proceed about changelog |
|
We generate the changelog for a version automatically by parsing all the PRs that are merged into that version, our script takes the |
|
nice 👍 |
memsharded
approved these changes
Oct 24, 2018
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This was referenced Oct 31, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
conan-io#3671 Add attribute tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Added
topicsattribute to theConanFileto specify topics (a.k.a tags, a.k.a keywords) to the recipe.This PR is related to #3671
Also, I added
authoras default attribute when runningconan newDocs PR: conan-io/docs#875
developbranch, documenting this one.