Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reuse python requires exports #3661

Merged
merged 14 commits into from
Oct 26, 2018
Merged

Feature/reuse python requires exports #3661

merged 14 commits into from
Oct 26, 2018

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 2, 2018 •
edited
Loading

Changelog: Feature: Implement reusage of sources (exports_sources) in recipes used as python_requires().

Proposes to reuse source code from base python_requires, that can be exports_sources to the inheriting conanfiles

@memsharded memsharded added this to the 1.9 milestone Oct 2, 2018
@ghost ghost assigned memsharded Oct 2, 2018
@ghost ghost added the stage: review label Oct 2, 2018
@memsharded memsharded assigned lasote and unassigned memsharded Oct 11, 2018
lasote
lasote suggested changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but:

  • Solve conflicts
  • It deserves some docs in the python requires section explaining well the behavior. Probably the SCM behavior should be there.

@ghost ghost assigned memsharded Oct 26, 2018
@lasote lasote merged commit 085c014 into conan-io:develop Oct 26, 2018
@ghost ghost removed the stage: review label Oct 26, 2018
@lasote
Copy link
Contributor

lasote commented Oct 26, 2018

Created issue in the docs to recall it.

@lasote lasote mentioned this pull request Oct 26, 2018
Closed
@memsharded memsharded deleted the feature/reuse_python_requires_exports branch October 26, 2018 16:58
grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018
@memsharded @lasote
Feature/reuse python requires exports (conan-io#3661)
2171cf1 
* reuse python requires exports

* doing only copy of exports_sources for building

* new test to check python requires class attrs

* complete_source and export instead of copy

* more checks

* format

* fixing tests

* fix broken test

* ready for revision
@jgsogo jgsogo mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote requested changes

Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@memsharded @lasote