Validate ConanFileReference only if requested #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danimtb
reviewed
Sep 26, 2018
| @@ -61,25 +61,29 @@ class ConanFileReference(namedtuple("ConanFileReference", "name version user cha | |||
| sep_pattern = re.compile("@|/|#") | |||
| revision = None | |||
|
|
|||
| def __new__(cls, name, version, user, channel, revision=None): | |||
| def __new__(cls, name, version, user, channel, revision=None, validate=True): | |||
There was a problem hiding this comment.
Should validate defaulted to False and only validate in the ConanFileReference loading points?
There was a problem hiding this comment.
I feel safer if we keep the previous behavior (always validating), at least in this pull request. Afterward, we can force it to be explicit and decide at each point if validation is needed or not.
lasote
approved these changes
Sep 26, 2018
danimtb
approved these changes
Sep 26, 2018
|
Updated PR description with changelog. Feel free to change it if not accurate enough |
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* check that parameters are string before applying regex match * add tests related to ConanName * typo * update docs related to function * use six to check for string types * use a custom message to validate each field * refactor tests to validate custom messages * fix tests: message is more explicit * given conan-io#3464 this is dead code * format error message only if we are actually going to use it * minor changes: address @lasote review * optional validation of conanfile reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3509
This could speed things up a little bit if passing
validate=False, current implementation add this flexibility while preserving existing behavior.Changelog: Feature: Validate parameter for ConanFileReference objects to avoid unnecessary checks