Do not modify generators files if nothing has changed (close #2895) #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
danimtb
approved these changes
Aug 28, 2018
| @@ -112,20 +112,28 @@ def save_append(path, content): | |||
| handle.write(to_file_bytes(content)) | |||
|
|
|||
|
|
|||
| def save(path, content): | |||
| def save(path, content, only_if_modified=False): | |||
There was a problem hiding this comment.
As this is only used internally (tools.save() is not affected by this) and mostly for testing (I think). Would it be possible to benefit from a defaulted only_if_modified=True?
There was a problem hiding this comment.
No, do not change the current default, dangerous. And I don't see the benefit, you mean performance? I doubt it, it will be slower.
|
yes, I will add some for the |
lasote
approved these changes
Aug 28, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
Do not modify generators files if nothing has changed (close conan-io#2895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter
only_if_modifiedto the utility functionsaveto skip actual writing to disk if nothing has changed.Implement this functionality in generators generated files.
Changelog: Fix: The generator files are only written in disk if the content of the generated file changes.