Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report remote while requesting login #17178

Conversation

marlamb
Copy link
Contributor

@marlamb marlamb commented Oct 16, 2024

Changelog: Fix: Add remote name to login prompt.
Docs: Omit
In setups with multiple remotes configured the prompt to enter a password might appear multiple times. After the first input users could deduce that the given password is wrong and in worst case start trying other ones, even if it was correct. Naming the remote name in the prompt as well will avoid such kind of confusion.

In setups with multiple remotes configured the prompt to enter a
password might appear multiple times. After the first input users could
deduce that the given password is wrong and in worst case start trying
other ones, even if it was correct. Naming the remote name in the prompt
as well will avoid such kind of confusion.
@marlamb
Copy link
Contributor Author

marlamb commented Oct 16, 2024

  • As it is a very small issue I did not care about opening an issue, but applied the fix directly.
  • I have read the contributing guide.
  • I followed PEP8 to my best knowledge.
  • I did not open a PR on the Conan docs repository, as the change seems too small to affect the documentation.

@memsharded memsharded self-assigned this Oct 16, 2024
@AbrilRBS
Copy link
Member

Thanks a lot @marlamb for taking the time to improve this, we appreciate it :)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also he released as part of 2.8.1 if it lines up, will check with the team!

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contribution.
This is indeed a good addition, totally makes sense, lets get it for next release

@memsharded memsharded added this to the 2.9.0 milestone Oct 16, 2024
@AbrilRBS AbrilRBS merged commit dfcb681 into conan-io:develop2 Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants