Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved exceptions conans->conan #17126

Merged
merged 1 commit into from
Oct 8, 2024
Merged

moved exceptions conans->conan #17126

merged 1 commit into from
Oct 8, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 7, 2024 •
edited by czoido
Loading

Changelog: Fix: Moved exceptions from the legacy from conans.error to documented from conan.error.
Docs: conan-io/docs#3864

Pure refactor moved:

  • public exceptions from conans.errors->conan.errors
  • private exceptions from conans.errors -> conan.internal.errors

@memsharded memsharded added this to the 2.9.0 milestone Oct 7, 2024
@memsharded memsharded requested a review from AbrilRBS October 8, 2024 07:43
AbrilRBS
AbrilRBS approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checked CCI, besides 1 v1-only recipe, we have no imports to the conans variant there, nor any recipe that requires a revision where this happens 👍

@czoido czoido merged commit dcea8d9 into conan-io:develop2 Oct 8, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the refactor/exceptions branch October 8, 2024 07:58
@snickl snickl mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @czoido @AbrilRBS