Fix RuntimeLibrary deduced from profile in MSBuildToolchain

[SpaceIm]

Changelog: Fix: Properly deduce RuntimeLibrary from profile in MSBuildToolchain.
Docs: Omit

closes #17099

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

[memsharded]

Hi @SpaceIm

Many thanks for your contribution.

It would be necessary to add some tests that covers it, I think it is enough to add some integration tests that checks the resulting toolchain.props file result.

This diff is actually changing 2 different things, and both should be covered by tests:

• The runtime_type that is not being honored, which I agree it looks like a gap to solve
• The fact that only msvc and intel-cc define runtime=static/dynamic, which means that other compilers were not adding a runtime library, because MT/MD are no longer valid compiler.runtime values in the default settings. This also looks like a gap, but it would be important to explicitly acknowledge it in the tests, making sure that it is fine for clang compiler toolset in MSVC to add the <RuntimeLibrary>

[SpaceIm]

I agree. I'll try to implement several tests.

[SpaceIm]

I've extended integration tests in order to cover runtime_type in MSBuildToolchain.
Regarding ClangCL, it requires more work since I have also to rethink the tests since integration test of MSBuildToolchain also checks PlatformToolset (more complicated with ClangCL, since there is also an extra setting runtime_version), and it's out of scope of this PR.

[memsharded]

Thanks for adding the test and your contribution!