Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_type on componet's get_property #16848

Merged

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Aug 20, 2024

Changelog: Feature: Add check_type on components get_property.
Docs: conan-io/docs#3815

Close: #16042

Additional work will come in a follow up PR, this implements the basic feature.

  • Add checks in the rest of get_property
  • Add support for this feat on places like cmakedeps

@ErniGH ErniGH added this to the 2.7.0 milestone Aug 20, 2024
@ErniGH ErniGH requested review from AbrilRBS and memsharded August 20, 2024 12:51
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@memsharded
Copy link
Member

Add checks in the rest of get_property

Probably not necessary to add a check_type=str for all of them, I'd add just those that are not strings

@czoido czoido merged commit 364c8d8 into conan-io:develop2 Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if it makes sense to guard against mistypes in certain properties
4 participants