Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[settings] subsettings from fake settings #16642

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[settings] subsettings from fake settings #16642

merged 4 commits into from
Jul 12, 2024

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jul 10, 2024 •
edited by czoido
Loading

Changelog: Bugfix: Avoid settings.update_values() failing when deducing compatibility.
Docs: omit

cc @AbrilRBS

@franramirez688 franramirez688 added this to the 2.6.0 milestone Jul 10, 2024
@franramirez688 franramirez688 marked this pull request as ready for review July 10, 2024 08:58
memsharded
memsharded approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, good job

test/unittests/model/settings_test.py Show resolved Hide resolved
conans/model/settings.py Outdated Show resolved Hide resolved
AbrilRBS
AbrilRBS approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix :)

@franramirez688 franramirez688 merged commit 8485417 into conan-io:develop2 Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@franramirez688 @AbrilRBS @memsharded