Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qbs: add explicit resolve method #16449

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

ABBAPOH
Copy link
Contributor

@ABBAPOH ABBAPOH commented Jun 10, 2024

Changelog: Feature: Added resolve() method to the Qbs toolchain.
Docs: Omit

Most tools have a separate configuration step and Qbs is no different. It's strange that the API doesn't provide a separate method for this. Add it now so that users can understand better what went wrong during which stage.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Most tools have a separate configuration step and Qbs is no
different. It's strange that the API doesn't provide a separate
method for this. Add it now so that users can understand better
what went wrong during which stage.
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the resolve step is mostly a project configure step, but in Qbs it is named resolve?

I think this looks good then. Just a minor detail about the migration path.

conan/tools/qbs/qbs.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 2.5.0 milestone Jun 11, 2024
@memsharded memsharded merged commit 2f1badc into conan-io:develop2 Jun 12, 2024
2 checks passed
@ABBAPOH ABBAPOH deleted the qbs-resolve branch July 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants