Delegate error handling to command framework instead of graph formatters #16415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jun 6, 2024
| return install_order_serialized | ||
|
|
||
| return {"build_order": install_order_serialized, | ||
| "conan_error": result.get_errors()} |
There was a problem hiding this comment.
Is this even possible? How can a build-order-merge have errors?
Make conan graph <subcommand> a real "install" dry-run. Return same errors and give same messages
perseoGI
force-pushed
the
16393-consistent-graph-command
branch
from
1c4a009 to
d89b5b9
Compare
memsharded
reviewed
Jul 1, 2024
memsharded
reviewed
Jul 1, 2024
memsharded
reviewed
Jul 2, 2024
conans/client/graph/install_graph.py
Outdated
Comment on lines
480
to
485
| def get_errors(self): | ||
| try: | ||
| self.raise_errors(basic_output=True) | ||
| except ConanException as e: | ||
| return str(e) | ||
| return None |
There was a problem hiding this comment.
It looks like that instead of modifying the _raise_missing and doing this, it would be better to craft its own simpler message here.
There was a problem hiding this comment.
But raise_errors could potentially raise invalid binaries errors also.
There was a problem hiding this comment.
Yes, sure, it can iterate all packages and add an error message line for each invalid and missing.
memsharded
approved these changes
Jul 2, 2024
AbrilRBS
approved these changes
Jul 31, 2024
memsharded
approved these changes
Jul 31, 2024
Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
memsharded
approved these changes
Jul 31, 2024
memsharded
approved these changes
Jul 31, 2024
czoido
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Make conan graph a real "install" dry-run. Return same errors and give same messages
Docs: omit
Close #16393
developbranch, documenting this one.