Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'compiler_executable' conf to work with Meson when path has spaces #16307

Conversation

juansblanco
Copy link
Contributor

@juansblanco juansblanco commented May 20, 2024

Changelog: Bugfix: Avoid sanitizing tools.build:compiler_executables value in MesonToolchain.
Docs: Omit

Close: #16212

@juansblanco juansblanco added this to the 2.4.0 milestone May 20, 2024
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @juansblanco! A couple of comments 😉

conan/tools/meson/toolchain.py Outdated Show resolved Hide resolved
juansblanco and others added 2 commits May 20, 2024 15:05
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
juansblanco and others added 2 commits May 20, 2024 16:08
@czoido czoido requested a review from franramirez688 May 20, 2024 14:44
@czoido czoido assigned franramirez688 and unassigned czoido May 20, 2024
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franramirez688 franramirez688 merged commit 84a3455 into conan-io:develop2 May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] tools.build:compiler_executables won't work with Meson due to spaces in the compiler path
4 participants