Disallow info access in source() method #16272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
May 16, 2024
gregmedd
added a commit
to gregmedd/up-cpp
that referenced
this pull request
Jun 5, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were using in our recipes. See conan-io/conan#16272 Additionally, the old way of passing the conan cache was brittle, so it has been switched to an artifact. Lastly, a fixed conan profile is set to reduce the risk of changes breaking things.
gregmedd
added a commit
to gregmedd/up-cpp
that referenced
this pull request
Jun 5, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were using in our recipes. See conan-io/conan#16272 Additionally, the old way of passing the conan cache was brittle, so it has been switched to an artifact. Lastly, a fixed conan profile is set to reduce the risk of changes breaking things.
BishrutSubedi
pushed a commit
to BishrutSubedi/up-cpp
that referenced
this pull request
Jun 7, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were using in our recipes. See conan-io/conan#16272 Additionally, the old way of passing the conan cache was brittle, so it has been switched to an artifact. Lastly, a fixed conan profile is set to reduce the risk of changes breaking things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Disallow
self.infoaccess insource()method.Docs: Omit
As mentioned in #15666,
self.infoaccess in thesource()method was a leak - it was not intended to be used inside said method, and accesses to the attribute were a bug by design, as the source method must not rely on configuration values to change its behaviourAlso adds some more beloved light=True in this file for those tests that pass with it