options patterns warning #16233
Merged
options patterns warning #16233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
May 14, 2024
AbrilRBS
reviewed
May 14, 2024
conan/api/subapi/profiles.py
Outdated
| ConanOutput().warning("Unscoped option definition is ambiguous.\n" | ||
| f"Use '&:{k}={v}' to refer to the current package.\n" | ||
| f"Use '*:{k}={v}' or other pattern if the intent was to apply to " | ||
| f"dependencies") |
There was a problem hiding this comment.
I'd add a tag here too, but not sure which one
There was a problem hiding this comment.
legacy seems to be a winner here
…eps (conan-io#16231) * add legacy variable prefix for cmakedeps * fix implementation * improve template variables * simplify code * improve test * add support for multiple cmake variable names and simplify test * improve code
memsharded
added
type: feature
component: ux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Warn when using
optionswithout pattern scope, to improve UX of users expecting-o shared=Trueto apply to dependencies.Docs: conan-io/docs#3720