Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MesonToolchain] Added tools.build:defines conf to 'conan list' #16228

Merged
merged 1 commit into from
May 9, 2024
Merged

[MesonToolchain] Added tools.build:defines conf to 'conan list' #16228

merged 1 commit into from
May 9, 2024

Conversation

paulharris
Copy link
Contributor

@paulharris paulharris commented May 9, 2024 •
edited by czoido
Loading

Changelog: Omit
Docs: Omit

Addition to documentation, follow up to docs#3709

No need to add further info to documentation.

AbrilRBS
AbrilRBS approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot for noticing and taking the time to create the PR :)

@AbrilRBS AbrilRBS self-assigned this May 9, 2024
@AbrilRBS AbrilRBS added this to the 2.4.0 milestone May 9, 2024
@AbrilRBS AbrilRBS changed the base branch from develop2 to release/2.3 May 9, 2024 06:37
@AbrilRBS AbrilRBS changed the base branch from release/2.3 to develop2 May 9, 2024 06:37
@AbrilRBS
Copy link
Member

AbrilRBS commented May 9, 2024

Seems like it'd be best if you could rebase this into the release/2.3 branch to be released for the next 2.3.1 release, thanks!

@AbrilRBS AbrilRBS modified the milestones: 2.4.0, 2.3.1 May 9, 2024
@paulharris
[MesonToolchain] Added tools.build:defines conf to 'conan list'
714086e 
Addition to documentation, follow up to docs#3709
@paulharris paulharris force-pushed the mesontoolchain_defines_doc branch from 133cdc1 to 714086e Compare May 9, 2024 07:32
@paulharris paulharris changed the base branch from develop2 to release/2.3 May 9, 2024 07:34
@paulharris
Copy link
Contributor Author

Rebased!

AbrilRBS
AbrilRBS approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The docs will get updated automatically once the new update lands :)

@AbrilRBS AbrilRBS merged commit cab4f18 into conan-io:release/2.3 May 9, 2024
2 checks passed
@paulharris paulharris deleted the mesontoolchain_defines_doc branch May 16, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@paulharris @AbrilRBS