extend conan version to report current python and system for troubleshooting
#16102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Apr 18, 2024
conan/cli/commands/version.py
Outdated
| 'system': { | ||
| 'version': platform.version(), | ||
| 'platform': platform.platform(), | ||
| 'os': platform.system() + ' ' + platform.release(), |
There was a problem hiding this comment.
These two can return an empty string.
If release is empty, then the field would be "Linux " which might be tricky for downstream users to properly parse if that happens to them :)
There was a problem hiding this comment.
Do we prefer to divide it in two? something like this:
Suggested change
| 'os': platform.system() + ' ' + platform.release(), | |
| 'version': platform.version(), | |
| 'platform': platform.platform(), | |
| 'os_system': platform.system(), | |
| 'os_release':platform.release(), |
There was a problem hiding this comment.
Reads better, but not too sold on the names with the prefix. No strong opinions either!
There was a problem hiding this comment.
Probably just system and release is good.
I'd say better them separately, this is structured information, better separated than us artificially joining them with _
Co-authored-by: James <memsharded@gmail.com>
AbrilRBS
approved these changes
Apr 18, 2024
franramirez688
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Extend
conan versionto report current python and system for troubleshooting.Docs: conan-io/docs#3691
Close: #15974