refactor apple_min_version_flag() #16017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neverminda
reviewed
Apr 4, 2024
…sToolchain and MesonToolchain for now)
| @@ -82,40 +85,3 @@ def test_to_apple_arch(self): | |||
| self.assertEqual(_to_apple_arch('armv8_32'), 'arm64_32') | |||
| self.assertIsNone(_to_apple_arch('mips')) | |||
| self.assertEqual(_to_apple_arch('mips', default='mips'), 'mips') | |||
|
|
|||
| @pytest.mark.skipif(platform.system() != "Darwin", reason="Requires OSX") | |||
| def test_xcrun(self): | |||
There was a problem hiding this comment.
Moved to integration tests. It's running xcrun tool so, IMO, better to keep it there.
memsharded
commented
Apr 8, 2024
conans/test/unittests/client/toolchain/autotools/autotools_toolchain_test.py
Outdated
Show resolved
Hide resolved
| """ | ||
| if not is_apple_os(conanfile): | ||
| # Keeping legacy defaults | ||
| return "", None, None |
There was a problem hiding this comment.
@memsharded keeping legacy behavior.
franramirez688
approved these changes
Apr 8, 2024
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Apr 9, 2024
* refactor apple_min_version_flag() * Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now) * Fixed bad return * Fixing tests * Keeping legacy behavior in apple_min_version_flag function * Preventing possible breaking change --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Apr 10, 2024
* refactor apple_min_version_flag() * Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now) * Fixed bad return * Fixing tests * Keeping legacy behavior in apple_min_version_flag function * Preventing possible breaking change --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
memsharded
added a commit
that referenced
this pull request
Apr 11, 2024
* cmake deps internal refactor for readability * fix * fix * fix * fix * fix * copy only if different (#16031) * allow conf in exports-sources and export (#16034) * refactor apple_min_version_flag() (#16017) * refactor apple_min_version_flag() * Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now) * Fixed bad return * Fixing tests * Keeping legacy behavior in apple_min_version_flag function * Preventing possible breaking change --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> * Allow to unhide git url (#16038) * Add hide_url tests for git scm tool * Add hide_url flag to clone and fetch_commit. Resolves #15684 * Update conans/test/functional/tools/scm/test_git.py * Update conans/test/functional/tools/scm/test_git.py --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * remove repeated non-running test (#16053) * refactor transitive_requires --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> Co-authored-by: Sebastian Höffner <info@sebastian-hoeffner.de> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
czoido
pushed a commit
that referenced
this pull request
Jun 4, 2024
* wip * wip * wip * Test for BazelDeps in the build context (#16025) * feat add test to bazeldeps * Fixed several bugs. Improved tests coverage * Reverted * Better name --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> * copy only if different (#16031) * allow conf in exports-sources and export (#16034) * refactor apple_min_version_flag() (#16017) * refactor apple_min_version_flag() * Refactored all the apple module and where it was being used (AutotoolsToolchain and MesonToolchain for now) * Fixed bad return * Fixing tests * Keeping legacy behavior in apple_min_version_flag function * Preventing possible breaking change --------- Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> * Allow to unhide git url (#16038) * Add hide_url tests for git scm tool * Add hide_url flag to clone and fetch_commit. Resolves #15684 * Update conans/test/functional/tools/scm/test_git.py * Update conans/test/functional/tools/scm/test_git.py --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * wip * wip * wip * fix * Update conan/tools/build/cstd.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update conan/tools/build/cstd.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update conan/tools/build/cstd.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> --------- Co-authored-by: Ernesto de Gracia Herranz <vivalaburocracia@hotmail.com> Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com> Co-authored-by: Sebastian Höffner <info@sebastian-hoeffner.de> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Close #15494