Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GCC14 detection #15958

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Add support for GCC14 detection #15958

merged 2 commits into from
Apr 1, 2024

Conversation

nagayev
Copy link
Contributor

@nagayev nagayev commented Mar 26, 2024

Changelog: Fix: Add gcc 14 to default settings.yml.
Docs: Omit

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @nagayev

It would be important to double check that the default c++ standard is not being changed by this compiler version, I haven't seen anything in the release notes, but better be sure.

conans/client/conf/__init__.py Outdated Show resolved Hide resolved
@memsharded memsharded added this to the 2.3.0 milestone Mar 26, 2024
Co-authored-by: James <memsharded@gmail.com>
@memsharded
Copy link
Member

It would be important to double check that the default c++ standard is not being changed by this compiler version, I haven't seen anything in the release notes, but better be sure.

@nagayev did you manage to check this? It would be great to double check it.

@nagayev
Copy link
Contributor Author

nagayev commented Mar 31, 2024

@memsharded Yes. As I can see at
https://gcc.gnu.org/projects/cxx-status.html
the c++ 20 support is not full yet and the default version is c++17

@memsharded
Copy link
Member

Page https://gcc.gnu.org/gcc-14/changes.html also doesn't refer any change in this respect

@memsharded memsharded merged commit 846519e into conan-io:develop2 Apr 1, 2024
2 checks passed
@nagayev nagayev deleted the gcc14 branch September 13, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants