[MesonToolchain] Added native mechanism when cross-building
#15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Mar 22, 2024
franramirez688
commented
Mar 26, 2024
franramirez688
force-pushed
the
frm/mesontoolchain_both_files
branch
2 times, most recently
from
a0fab76 to
f4831bd
Compare
franramirez688
commented
Apr 12, 2024
| machine_files.insert(0, native) | ||
| cmd += "".join([f'--native-file "{file}"' for file in machine_files]) | ||
| else: # extra native file for cross-building scenarios | ||
| cmd += f' --native-file "{native}"' |
There was a problem hiding this comment.
I'm keeping the old behavior.
franramirez688
commented
Apr 12, 2024
| # Forcing to create the native context too | ||
| if cross_building(self): | ||
| tc = MesonToolchain(self, native=True) | ||
| tc.generate() |
There was a problem hiding this comment.
I decided to keep this quite explicit, but I'm open to talking more 😁
franramirez688
changed the title
native mechanism when cross-building
danimtb
approved these changes
Apr 29, 2024
memsharded
reviewed
Apr 29, 2024
conans/test/functional/toolchains/meson/test_meson_native_attribute.py
Outdated
Show resolved
Hide resolved
…ibute.py Co-authored-by: James <memsharded@gmail.com>
franramirez688
force-pushed
the
frm/mesontoolchain_both_files
branch
from
5d23e79 to
8b3ff07
Compare
memsharded
reviewed
Apr 30, 2024
memsharded
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: MesonToolchain can generate a native file if native=True (only makes sense when cross-building).
Changelog: Feature: Meson helper injects native and cross files if both exist.
Docs: conan-io/docs#3710
Closes: #15878