-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove existing 'file' arg when overwriting print #15912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this @dasimmet
Could you please sign the CLA?
I think the fix is good, and can be merged, maybe a unit test that covers this case could help to avoid future breakage. We can contribute the test if you want.
We might try to release this in a 2.2.2 release, I'll sync with the team.
It is also possible that you did the commit with a different email rather than the one in your Github account, and that also confuses the CLA. |
yes i did and rewrote it now to my gh email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
This might be released in a 2.2.2 patch depending on the impact. Can you easily fix/workaround it from your side? |
yes, thanks. I can stay with 2.1 until it is released. |
* remove existing 'file' arg when overwriting print * add unittest for new_print override
* remove existing 'file' arg when overwriting print * add unittest for new_print override
Changelog: Fix: Fix broken calls to
print(x, file=y)
with duplicate keyword arguments.Docs: Omit
To prevent this, when overwriting the print() function overwrite the existing 'file' argument
develop
branch, documenting this one.