Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise for toolchains different than CMakeToolchain if using universal binary syntax #15896

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Raise for toolchains different than CMakeToolchain if using universal binary syntax #15896

merged 3 commits into from
Mar 19, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Mar 19, 2024

Changelog: Feature: Raise for toolchains different than CMakeToolchain if using universal binary syntax.
Docs: Omit

I'll add a note to the docs for the universal binaries

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@czoido czoido added this to the 2.2.0 milestone Mar 19, 2024
@czoido czoido requested a review from memsharded March 19, 2024 16:40
memsharded
memsharded approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conans/test/integration/toolchains/test_raise_on_universal_binaries.py Outdated

client.run('create . --name=foo --version=1.0 -s="arch=armv8|armv8.3|x86_64"',
assert_error=True)
assert "Universal binaries not supported by toolchain." in client.out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making sure that the package name and generator is in the error message would be nice.

@czoido czoido merged commit caad83b into conan-io:develop2 Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@czoido @memsharded