Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print options conflicts #15876

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 14, 2024

Changelog: Feature: Print options conflicts in the graph caused by different branches recipes defining options values.
Docs: conan-io/docs#3643

Close #15865

@memsharded memsharded added this to the 2.2.0 milestone Mar 14, 2024
@zhanglin-zhou
Copy link

Thanks very much for your fix, @memsharded. Based on testing for the simple recipe in issue #15865:

  1. When I change the order of zlib and libpng in recipe, then no warning. Do you think we still need to output conflict options here? Because conflict still happen.
  2. zlib/1.3:shared=False (current value) is it possible to output like zlib/1.3:shared=False (current value from libpng/1.6.43)? So that people can know when it comes from.

I will integrate your patch to our product, which is complex project to see what happen.

@memsharded
Copy link
Member Author

When I change the order of zlib and libpng in recipe, then no warning. Do you think we still need to output conflict options here? Because conflict still happen.

Not really,libpng is not defining options values for zlib. The detection only checks the options explicitly set in recipes. If they succeed in setting the value, and there is no other recipe trying to do the same and conflicting, it is not necessary to report it.

zlib/1.3:shared=False (current value) is it possible to output like zlib/1.3:shared=False (current value from libpng/1.6.43)? So that people can know when it comes from.

I am afraid that would be a bit too costly. At the moment, only when a diamond in the graph is being closed this is triggered, but to be able to print this, it would be necessary to store that information for every graph requirement expansion.

@czoido czoido merged commit 9635004 into conan-io:develop2 Mar 18, 2024
2 checks passed
@memsharded memsharded deleted the feature/print_options_conflicts branch March 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Conan mixed requires which have different options
4 participants