Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conan create remote WIP #15856
conan create remote WIP #15856
Changes from all commits
7073730
d852ca8
acc000c
284e62e
9175aa6
03d53ca
559428b
62de035
c565352
ea4f495
b7072b9
de279ec
f8c7cc1
aa9dd9a
c913570
9f5b600
001014e
cbf0cf1
e169fd9
7fa7de4
be0fcb0
f0f7d6f
700176e
5e9d533
847c663
7fda3b5
9a9e298
84f6603
8fecd97
07232cd
8056359
6a44fbf
f151c3b
a54ecca
6e26f78
a6e1799
fa8ab58
2977c64
fb6bab8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the preference order in selecting from the profile or the config file a bit unnatural, because you can set in the profile contradictory things, like for example using a configfile that points to a dockerfile and be pointing in the profile to another one, shouldn't the configfile and the profile settings that overlap be incompatible in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not for this PR, but suggesting here that we make the default image name configurable with something like
core.runners.docker.default_image_name