Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: need return 3 None on detect_default_compiler() to avoid errors #15832

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: need return 3 None on detect_default_compiler() to avoid errors #15832

merged 2 commits into from
Mar 7, 2024

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Mar 7, 2024 •
edited by czoido
Loading

Changelog: Fix: Make sure detect_default_compiler() always returns a 3-tuple.
Docs: Omit

Close: #15712

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@ErniGH ErniGH added this to the 2.2.0 milestone Mar 7, 2024
@ErniGH ErniGH requested review from AbrilRBS and juansblanco March 7, 2024 14:20
AbrilRBS
AbrilRBS reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

conan/internal/api/detect_api.py Show resolved Hide resolved
@memsharded memsharded merged commit e226805 into conan-io:develop2 Mar 7, 2024
2 checks passed
@memsharded memsharded mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS left review comments

@franramirez688 franramirez688 franramirez688 left review comments

@memsharded memsharded memsharded approved these changes

@juansblanco juansblanco Awaiting requested review from juansblanco

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

[bug] Detecting profile crashes
4 participants
@ErniGH @franramirez688 @AbrilRBS @memsharded