CMakeToolchain: implement vs debugger path #15830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Mar 7, 2024
Comment on lines
140
to
147
| if os.path.exists(CONAN_TOOLCHAIN_FILENAME): | ||
| existing_include = load(CONAN_TOOLCHAIN_FILENAME) | ||
| vs_debugger_environment = re.search(r"set\(CMAKE_VS_DEBUGGER_ENVIRONMENT \"PATH=([^)]*)>;%PATH%\"\)", | ||
| existing_include) | ||
| if vs_debugger_environment: | ||
| capture = vs_debugger_environment.group(1) | ||
| matches = re.findall(r"\$<\$<CONFIG:([A-Za-z]*)>:(.*)", capture) | ||
| config_dict = dict(matches) |
There was a problem hiding this comment.
This is the part we might want to refactor, but that might be done later in another PR
There was a problem hiding this comment.
Removed the string generation from the jinja, and into python, although still very tricky to get right with the regexes. Fixed some issues when we have more than 2 configs, so it should be more robust.
IN a later PR I have some ideas for how to support multiconfig in a more straightforward way
memsharded
reviewed
Mar 10, 2024
franramirez688
approved these changes
Mar 12, 2024
memsharded
approved these changes
Mar 12, 2024
memsharded
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Set
CMAKE_VS_DEBUGGER_ENVIRONMENTfrom CMakeToolchain to point to all binary directories when using Visual Studio. This negates the need to copy DLLs to launch executables from the Visual Studio IDE (requires CMake 3.27 or newer).Docs: conan-io/docs#3639