Fix/platform requires with options #15804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
Mar 4, 2024
| @@ -209,7 +225,7 @@ def test_package_id_modes(self, package_id_mode): | |||
| or package_id | |||
| """ | |||
| client = TestClient() | |||
| save(client.cache.new_config_path, f"core.package_id:default_build_mode={package_id_mode}") | |||
| save(client.cache.new_config_path, f"core.package_id:default_unknown_mode={package_id_mode}") | |||
There was a problem hiding this comment.
This was a bit unrelated, but it was wrong, as this test was not using tool-requires
czoido
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Avoid
platform_requiresto fail when explicit options are being passed viarequires(.., options={}).Docs: Omit
Close #15685