Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conan profile show --format=json for profiles with scoped confs #15747

Merged

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Feb 23, 2024

Changelog: Bugfix: Fix conan profile show --format=json for profiles with scoped confs.
Docs: Omit

Weird that we didn't get it reported sooner, but this seems to have been here for some months now

Closes #15746

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising indeed. I'm even seeing tests that are using those confs:

  • conans/test/integration/configuration/conf/test_conf_profile.py
    • test_cmake_config_package
    • test_conf_package_patterns
    • test_config_package_append
    • test_conf_patterns_user_channel

@czoido czoido merged commit 2cf7c32 into conan-io:develop2 Feb 26, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/fix-scopedd-conf-serialization branch February 26, 2024 07:24
memsharded pushed a commit to memsharded/conan that referenced this pull request Feb 26, 2024
…conan-io#15747)

Fix conan profile show --format=json for profiles with scopd confs
czoido pushed a commit that referenced this pull request Mar 13, 2024
* wip

* wip

* wip

* wip

* wip

* wip

* package_id config_mode

* test

* wip

* trying auto

* wip

* fix conan_server timestamp truncation

* fix test

* wip

* wip

* lockfiles

* Update conan/cli/commands/config.py

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* Update conans/client/graph/graph_binaries.py

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* Update conans/test/functional/command/config_install_test.py

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>

* Fix `conan profile show --format=json` for profiles with scoped confs (#15747)

Fix conan profile show --format=json for profiles with scopd confs

* review

* fix issues and improve CMakeToolchain.preprocessor (#15756)

* fix issues and improve CMakeToolchain.preprocessor

* fix test

* list --profile argument (#15697)

* list --profile argument

* filtering

* fix PkgConfigDeps in build context (#15763)

fix PkgConfigDeps

* [CMakeToolchain]Adding visibility flag to CONAN_C_FLAGS (#15762)

Adding visibility flags to C flags too

* PkgConfigDeps refactor (#15771)

* allow self.name/self.version for build_folder_vars (#15705)

* wip

* wip

* wip

* wip

---------

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] conan profile show crashes when showing profilse with per-package conf variables
4 participants