Allow passing patterns to --update argument
#15652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Feb 12, 2024
AbrilRBS
commented
Feb 12, 2024
AbrilRBS
commented
Feb 12, 2024
AbrilRBS
commented
Feb 12, 2024
conan/cli/args.py
Outdated
| parser.add_argument("-u", "--update", action='store_true', default=False, | ||
| help=update_help) | ||
|
|
||
| parser.add_argument("-u", "--update", action="append", nargs="?", help=update_help, const=True) |
There was a problem hiding this comment.
const=True does not mean that the value is const, rather, when no argument is supplied, it will append True in this case to the list
memsharded
reviewed
Feb 12, 2024
AbrilRBS
commented
Feb 13, 2024
conan/cli/args.py
Outdated
| add_profiles_args(parser) | ||
|
|
||
|
|
||
| def protect_update(args): |
There was a problem hiding this comment.
Used to check in the tests that no leftover if update: is left, will remove before merging
AbrilRBS
changed the title
--update argument--update argument
czoido
approved these changes
Feb 13, 2024
memsharded
reviewed
Feb 13, 2024
memsharded
approved these changes
Feb 14, 2024
czoido
reviewed
Feb 15, 2024
| parser.add_argument("-u", "--update", action='store_true', default=False, | ||
| help=update_help) | ||
|
|
||
| parser.add_argument("-u", "--update", action="append", nargs="?", help=update_help, const="*") |
There was a problem hiding this comment.
I think we should also update the update_help text?
There was a problem hiding this comment.
Oops good catch, will do right now
czoido
approved these changes
Feb 15, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add ability to pass patterns to
--updateflag.Docs: conan-io/docs#3587
Got bitten because I wanted to update a specific package coming from a version range on a dependency graph, but thought that it was too wasteful to have the whole graph updated which I didnt care about.
The thing that took most of the time was checking the already present --update tests
Importantly, the old syntax still works and means "update all".
This helps to reduce processing time of graph computation when you want to update only specific references
Closes #2615