Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal for cli-commands api #15630

Merged
merged 8 commits into from
Feb 20, 2024
Merged

proposal for cli-commands api #15630

merged 8 commits into from
Feb 20, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Feb 8, 2024 •
edited by AbrilRBS
Loading

Changelog: Feature: New CommandAPI subapi in the ConanAPI that allows calling other commands.
Docs: conan-io/docs#3635

@memsharded memsharded requested review from jcar87 and czoido February 8, 2024 23:51
franramirez688
franramirez688 reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks really simple 👏

@jcar87
Copy link
Contributor

jcar87 commented Feb 9, 2024

I already have a few custom commands in mind if this is possible!! :D

@czoido czoido added this to the 2.2 milestone Feb 14, 2024
@memsharded memsharded marked this pull request as ready for review February 15, 2024 09:48
@memsharded memsharded modified the milestones: 2.2, 2.1 Feb 15, 2024
jcar87
jcar87 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AbrilRBS
AbrilRBS approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't check right now because the question came to my mind just after I closed the laptop for the day, but I assume this works just fine for custom commands, right?

Otherwise looks good and feels nice to use! 👍

@memsharded
Copy link
Member Author

Can't check right now because the question came to my mind just after I closed the laptop for the day, but I assume this works just fine for custom commands, right?

@RubenRBS you mean that one custom command can also call other custom command? Yes, it should, I can add a test to cover this.

@memsharded memsharded requested a review from AbrilRBS February 16, 2024 11:14
@czoido czoido merged commit e2a6d96 into conan-io:develop2 Feb 20, 2024
2 checks passed
@memsharded memsharded deleted the feature/api_cli branch February 20, 2024 10:54
@memsharded memsharded mentioned this pull request Mar 6, 2024
Closed
@AbrilRBS AbrilRBS mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

@jcar87 jcar87 jcar87 approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@czoido czoido

Labels
type: feature
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@memsharded @jcar87 @franramirez688 @czoido @AbrilRBS