Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added cross-building conf variable #15616

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[feature] Added cross-building conf variable #15616

merged 3 commits into from
Feb 7, 2024

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Feb 7, 2024 •
edited
Loading

Changelog: Feature: Added tools.build.cross_building:cross_build to decide whether cross-building or not regardless of the internal Conan mechanism.
Docs: omit
Closes: #15392

@franramirez688 franramirez688 added this to the 2.1 milestone Feb 7, 2024
memsharded
memsharded reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but test is broken, because the Mock doesn't implement the conf.get() correctly

@memsharded memsharded merged commit 1c18f76 into conan-io:develop2 Feb 7, 2024
2 checks passed
@memsharded memsharded mentioned this pull request Feb 7, 2024
Closed
@franramirez688 franramirez688 mentioned this pull request Mar 14, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

[bug] meson toolchain incorrectly handles cross-compilation on same os/arch tuple.
2 participants
@franramirez688 @memsharded